Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3504: Split actionable-proposals.derived.ts #6127

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Jan 9, 2025

Motivation

We want to sort the selectable universes based on their number of actionable proposals.
For this selectable-universes.derived.ts needs to depend on actionableProposalCountStore from actionable-proposals.derived.ts.
But this causes a circular dependency because of other derived stores in actionable-proposals.derived.ts which already depend on selectable-universes.derived.ts.

Changes

  1. Move the derived stores in actionable-proposals.derived.ts that depend on selectable-universes.derived.ts to a new file named actionable-universes.derived.ts.
  2. Update imports.

Tests

  1. Move tests for the moved stores to a corresponding test file.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review January 9, 2025 11:12
@dskloetd dskloetd requested a review from a team as a code owner January 9, 2025 11:12
@dskloetd dskloetd enabled auto-merge January 9, 2025 11:12
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dskloetd dskloetd added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit d7aa761 Jan 9, 2025
31 checks passed
@dskloetd dskloetd deleted the kloet/actionable-universes branch January 9, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants