NNS1-3504: Split actionable-proposals.derived.ts #6127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to sort the selectable universes based on their number of actionable proposals.
For this
selectable-universes.derived.ts
needs to depend onactionableProposalCountStore
fromactionable-proposals.derived.ts
.But this causes a circular dependency because of other derived stores in
actionable-proposals.derived.ts
which already depend onselectable-universes.derived.ts
.Changes
actionable-proposals.derived.ts
that depend onselectable-universes.derived.ts
to a new file namedactionable-universes.derived.ts
.Tests
Todos
not necessary